Do not show the main event warning if competition has only one event #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxidragon
force-pushed
the
main-event-warning
branch
from
ed8381f to
71ee7db
Compare
|
Hi @maxidragon can you please let me know if this was discussed in any WRT emails or slack? I've been away for few days, so might have missed if there was one. This is really good change actually and I'm totally fine with this change if this has been already informed to the team. |
|
Yeah, this is the request from @c-goodyear |
danieljames-dj
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. It's quite clearly that if the event is the only event, it was treated in a special way and there is no need to show this warning.